minor code quality improvements #7177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
force-pushed
the
code-quality
branch
from
f99b7ab to
404199b
Compare
danieleades
force-pushed
the
code-quality
branch
3 times, most recently
from
bc95131 to
5ff8cce
Compare
Contributor
|
looks cool :) |
Contributor
Author
there's a mixture, but a lot of these are from |
danieleades
force-pushed
the
code-quality
branch
2 times, most recently
from
4972fbe to
2f506c4
Compare
|
GNU testsuite comparison: |
Contributor
|
Could you please merge all patches into one and explain that it is identified by clippy and add the 'name of the rule? Thanks |
Contributor
Author
i think you can do this using the 'squash merge' pull request feature, no? |
Contributor
|
yes but I think you could write a proper commit message :) |
danieleades
force-pushed
the
code-quality
branch
from
2f506c4 to
f3f3c30
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
danieleades
force-pushed
the
code-quality
branch
from
27b3c4e to
f3f3c30
Compare
danieleades
force-pushed
the
code-quality
branch
from
f3f3c30 to
3c69e50
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.