Skip to content

Clippy Pedantic Acceptable Commits #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcampbell24 wants to merge 10 commits into from
Closed

Clippy Pedantic Acceptable Commits #6738

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5d986bf
Fix clippy::manual_assert.
dcampbell24 Sep 19, 2024
353eb53
Fix clippy::uninlined_format_args .
dcampbell24 Sep 19, 2024
feae527
Fix clippy::unnecessary_join.
dcampbell24 Sep 19, 2024
cff8cc0
Fix clippy::unreadable_literal.
dcampbell24 Sep 19, 2024
d0e30b2
Fix clippy::inconsistent_struct_constructor.
dcampbell24 Sep 19, 2024
392344c
Fix clippy::cloned_instead_of_copied.
dcampbell24 Sep 19, 2024
3c26dd8
Fix clippy::flat_map_option.
dcampbell24 Sep 19, 2024
226a570
Fix format_collect.
dcampbell24 Sep 25, 2024
a266b79
Update src/uucore/src/lib/features/checksum.rs
dcampbell24 Sep 28, 2024
0a49173
Rename bytes to hex, allocate String with capacity.
dcampbell24 Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/uucore/src/lib/features/checksum.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ use crate::{
},
util_name,
};
use std::fmt::Write;
use std::io::stdin;
use std::io::BufRead;
use thiserror::Error;
Expand Down Expand Up @@ -321,10 +322,10 @@ fn determine_regex(lines: &[String]) -> Option<(Regex, bool)> {

// Converts bytes to a hexadecimal string
fn bytes_to_hex(bytes: &[u8]) -> String {
bytes
.iter()
.map(|byte| format!("{byte:02x}"))
.collect::<String>()
bytes.iter().fold(String::new(), |mut bytes, byte| {
write!(bytes, "{byte:02x}").unwrap();
bytes
})
}

fn get_expected_checksum(
Expand Down