tee: Correctly handle read-only files, avoid unnecessary wrapping #6157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes two layers of Box<NamedWriter<...>>. The indirection appears to be unintentional, and makes it harder to understand and change the code.
sylvestre
reviewed
Mar 31, 2024
BenWiederhake
force-pushed
the
dev-tee-fail-open
branch
from
b32b3b0
to
a4aaadc
Compare
|
Changes since last push: - let path = PathBuf::from(name.clone());
+ let path = PathBuf::from(name);As suggested by clippy stable, clippy nightly, and @sylvestre :D |
|
GNU testsuite comparison: |
BenWiederhake
force-pushed
the
dev-tee-fail-open
branch
from
a4aaadc
to
675dd94
Compare
|
Changes since last push:
|
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly fixes the handling of writing to existing read-only files, and adds
test_readonly().As a drive-by improvement, this PR also removes some weird wrapping that seems to be unintentional leftovers from history. In short, we used to have a NamedWriter that contained a NamedWriter that contained a NamedWriter that contained the actual file. The run-time impact should be negligible, but removing it makes the code a bit easier to read and edit.
The inspiration for this PR was working towards fixing the GNU test
misc/tee.log. Note that we still don't fully pass this test because we don't implement "iopoll-powered early exit for closed pipes".