-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
env
argv0 overwrite possibility (unix only) - fixes new gnu test version
#6154
env
argv0 overwrite possibility (unix only) - fixes new gnu test version
#6154
Conversation
45e2574
to
f3e2b2e
Compare
GNU testsuite comparison:
|
fbb5f79
to
dfb629b
Compare
GNU testsuite comparison:
|
are you sure you fixed it ? :) |
sorry, I was apparently a bit quick there. I forgot to add the patch for the test.
What do you think. Is it more important to replicate the GNU behaviour in this case? |
We could report bugs upstream to get this adjusted. |
GNU testsuite comparison:
|
364f98b
to
e8346fb
Compare
GNU testsuite comparison:
|
I might be missing some context, but:
That's actually the case for the vast majority of options (but not all of them, sigh), and there's a huge chunk of programs where we still do it wrong: #5998 In this case, simply doing |
@BenWiederhake thanks for pointing this out. |
e8346fb
to
6608a0d
Compare
GNU testsuite comparison:
|
6608a0d
to
0b5f098
Compare
GNU testsuite comparison:
|
f24d34f
to
e4216b3
Compare
GNU testsuite comparison:
|
b076824
to
e4216b3
Compare
GNU testsuite comparison:
|
e4216b3
to
92919cb
Compare
GNU testsuite comparison:
|
aee650a
to
e0a5878
Compare
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, just a few nitpicks about testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! I didn't realize that argument overrides across -S
already works.
I'm a bit uncertain how to add this to the repo; squashing it all seems like a bad idea (e.g. the changes to GNUmakefile
should be in a different commit than the actual argv0 changes), but the commits are also not atomic, so I can't just rebase it. I'll discuss this with the others.
In the meantime, please consider doing git-rebase -i origin/main
:)
GNU testsuite comparison:
|
3463e1c
to
1999902
Compare
1999902
to
3b8647c
Compare
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, and thanks for the rebase! :)
as discussed with @sylvestre here: #5801
this makes the gnu-test
tests/env/env.sh
green again.changes explained:
coreutils
executable to execute specific tools without placing seperate argument for tool-name