Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csplit: remove crate_name attribute #6091

Merged
merged 1 commit into from
Mar 18, 2024
Merged

csplit: remove crate_name attribute #6091

merged 1 commit into from
Mar 18, 2024

Conversation

cakebaker
Copy link
Contributor

While reviewing #6090 I noticed a crate_name attribute I think is unnecessary as no other util uses it. According to https://doc.rust-lang.org/rust-by-example/attribute/crate.html:

it is important to note that both the crate_type and crate_name attributes have no effect whatsoever when using Cargo, the Rust package manager.

@sylvestre sylvestre merged commit 7819cb3 into uutils:main Mar 18, 2024
61 of 62 checks passed
@sylvestre
Copy link
Contributor

TIL

@cakebaker cakebaker deleted the csplit_remove_crate_name_attribute branch March 18, 2024 09:27
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/dd/misc. tests/dd/misc is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/csplit/csplit is no longer failing!

@chenrui333 chenrui333 mentioned this pull request Mar 24, 2024
Merged
@moonfruit moonfruit mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre