df: switch from u64 to u128 to handle fs with large inodes nr #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
changed the title
cre4ture
force-pushed
the
fix/df_total_int_overflow_android
branch
2 times, most recently
from
eaab79c to
68679ea
Compare
|
GNU testsuite comparison: |
cre4ture
force-pushed
the
fix/df_total_int_overflow_android
branch
from
68679ea to
29844af
Compare
|
GNU testsuite comparison: |
There was a problem hiding this comment.
The u128 change is fine I think. I guess it's not compatible, but it feels correct. Having to deal with overflow here seems a bit like overflow though. I'd say that's an issue that we postpone for when someone actually runs into a real use case where u128 overflows. But if you have some use case for it we can discuss that.
src/uu/df/src/table.rs
Outdated
Comment on lines
21
to
22
| type InodesIntT = u128; | ||
| type MaybeInodesT = Option<InodesIntT>; |
There was a problem hiding this comment.
I appreciate the idea here, but I think it obfuscates the exact data type too much. Id rather just see Option<u128> everywhere than MaybeInodesT because then I actually know what I'm dealing with.
cre4ture
changed the title
cre4ture
force-pushed
the
fix/df_total_int_overflow_android
branch
from
bd87899 to
018758c
Compare
cre4ture
changed the title
|
GNU testsuite comparison: |
sylvestre
reviewed
Mar 15, 2024
cre4ture
force-pushed
the
fix/df_total_int_overflow_android
branch
from
667f5c3 to
eed7a53
Compare
cre4ture
force-pushed
the
fix/df_total_int_overflow_android
branch
from
eed7a53 to
6fa2c58
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #6070
changes:
u128for accumulating inodesuseOption<>additionally to handle overflows correctlyI know that u128 is slower than u64 as its probably not natively supported, but we are not accumulating millions of numbers such that it should not be significant.
ADDITION: