tests: Harden two tests, prevent 4 flaky tests (cat, numfmt, sort, split, tee) #6000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the tests:
test_tee_no_more_writeable_1
ignored memory problems, the newtest_check_unique_combined
exercises an input that wasn't possible before clap#2624)My goal was to find any flaky tests like 9995c63: When we write a large buffer to the stdin of a process that will fail at some point, then a race happens:
Arguably, these tests are unlikely to be the cause of any flakiness, but let's fix them anyway: Either it improves the situation, or makes no difference.