-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clippy suggestions #5895
Clippy suggestions #5895
Conversation
could you please update the CI to run these too ? |
I left open what should happen with extremely long Cases like these,
To my eyes, |
done for the trivial ones currently passing |
2b2b584
to
886d273
Compare
This adresses only those where the fix has less letters than the original and is "trivial" (There are possibly a lot of std::string::ToString::to_string and those may only be shortened with additional imports). Found with clippy::redundant-closure-for-method-calls
as suggested by clippy::range-plus-one
as suggested by clippy::range-plus-one
886d273
to
43212c6
Compare
thanks :) |
ran clippy with clippy::range-plus-one, clippy::redundant-closure-for-method-calls and fix those where I was confident this is
a) improvement to the reader
b) does not make lines longer, no additional imports