Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shuf: accept multiple occurances of head-count argument #3329

Merged
merged 6 commits into from Mar 28, 2022
Merged

shuf: accept multiple occurances of head-count argument #3329

merged 6 commits into from Mar 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 28, 2022

Closes #3328

@ghost
Copy link
Author

ghost commented Mar 28, 2022

I am not sure why the cargo fmt is failing in CICD. I don't see any issues locally. Any suggestions?

Run ## `cargo fmt` testing of integration tests
Diff in /home/runner/work/coreutils/coreutils/tests/by-util/test_shuf.rs at line 202:
     let result = new_ucmd!()
         .args(&["-i10-200", "-n", "10", "-n", "5"])
         .succeeds();
-    result.no_stderr();    
+    result.no_stderr();
     let result_seq: Vec<&str> = result
         .stdout_str()
         .split('\n')
Error: ERROR: `cargo fmt`: style violation (file:'tests/by-util/test_shuf.rs', line:202; use `cargo fmt "tests/by-util/test_shuf.rs"`)
Error: Process completed with exit code 1.

@sylvestre
Copy link
Contributor

tab vs space?

@ghost
Copy link
Author

ghost commented Mar 28, 2022

tab vs space?

No. All spaces locally. I am running cargo fmt locally and not getting any changes. I'll merge the last line per suggestion and see what happens.

@sylvestre
Copy link
Contributor

Is that expected?

Error: GNU test failed: tests/misc/shuf. tests/misc/shuf is passing on 'main'. Maybe you have to rebase?

@ghost
Copy link
Author

ghost commented Mar 28, 2022

Is that expected?

Error: GNU test failed: tests/misc/shuf. tests/misc/shuf is passing on 'main'. Maybe you have to rebase?

Nope. Let me check.

@ghost
Copy link
Author

ghost commented Mar 28, 2022

Is that expected?

Error: GNU test failed: tests/misc/shuf. tests/misc/shuf is passing on 'main'. Maybe you have to rebase?

We can see from the issue #3320 that tests/misc/shuf is marked as ERROR (in main). I am assuming the changes in this PR is marking the test as FAILED and hence the message in CICD.

We could see from below that the FAIL count is increased with the decrease of ERROR count. The message above is misleading. The test was not passing on main rather it was in error.

Reference SHA1/ID: 6910b655322894ad898c8aad42302a12aa182012  reference/test-summary/gnu-result.json
Warning: Changes from main: PASS +0 / FAIL +1 / ERROR -1 / SKIP +0 

@ghost
Copy link
Author

ghost commented Mar 28, 2022

Latest test result

Reference SHA1/ID: 6910b655322894ad898c8aad42302a12aa182012  reference/test-summary/gnu-result.json
Error: GNU test failed: tests/factor/t06. tests/factor/t06 is passing on 'main'. Maybe you have to rebase?
Error: GNU test failed: tests/factor/t11. tests/factor/t11 is passing on 'main'. Maybe you have to rebase?
Error: GNU test failed: tests/misc/shuf. tests/misc/shuf is passing on 'main'. Maybe you have to rebase?
Error: Process completed with exit code 255.

I already explained the reason for shuf in the earlier comment. I have no idea why t06 and t11 are failing. My change has nothing to do with those two tests.

@sylvestre
Copy link
Contributor

We can see from the issue #3320 that tests/misc/shuf is marked as ERROR (in main). I am assuming the changes in this PR is marking the test as FAILED and hence the message in CICD.

Oh, yeah, right. it is mentioned here:
#3320

well done :)

@sylvestre sylvestre merged commit 746e35c into uutils:main Mar 28, 2022
@ghost ghost deleted the shuf-gnu-test branch March 29, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

shuf: Accept multiple occurrences of head count argument
1 participant