Skip to content

refactor ~ improve code coverage implementation#1476

Merged
sylvestre merged 10 commits intouutils:masterfrom
rivy:rf.reorg-codecover
Apr 14, 2020
Merged

refactor ~ improve code coverage implementation#1476
sylvestre merged 10 commits intouutils:masterfrom
rivy:rf.reorg-codecover

Conversation

@rivy
Copy link
Contributor

@rivy rivy commented Apr 14, 2020

  • modifies GHA:CICD workflow to successfully calculate code coverage for macos, unix, and windows
  • uploads coverage maps to CodeCov.io (which can integrate reports from multiple platforms)
  • includes shortcut utilities to calculate and show locally generated code coverage

@rivy rivy requested a review from sylvestre April 14, 2020 04:51
@rivy
Copy link
Contributor Author

rivy commented Apr 14, 2020

@sylvestre , if you have some time, would you look at the "util/show-codecov.sh" shell script?

Specifically, I've marked three lines "FixME".

It's probably just a brain misfire, but I can't figure out how to code this to condense the ignore's for grcov into a variable and use it at the later two spots as an option to grcov. When I've tried to debug using echo ..., the command line seems correct, but grcov ignores the options included via ${GRCOV_IGNORE_OPTION}. And, so, I'm having to duplicate the ignores, writing them directly on the commands lines.
😕

@rivy
Copy link
Contributor Author

rivy commented Apr 14, 2020

As a reminder, I'll update the GHA:CICD workflow to include some appropriate grcov line and branch exclusions (eg, --excl-br-line 'assert(_eq|_ne)?!') when mozilla/grcov#416 is merged.

@rivy rivy force-pushed the rf.reorg-codecover branch from 8b7bdc7 to ce6b425 Compare April 14, 2020 19:25
@sylvestre
Copy link
Contributor

Yeah, bravo, thanks :)

@sylvestre sylvestre merged commit 36e945d into uutils:master Apr 14, 2020
@rivy rivy deleted the rf.reorg-codecover branch April 15, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants