numfmt: preserve fractional digits when --from-unit is used without suffix and fixed String format#11674
Merged
cakebaker merged 3 commits intouutils:mainfrom Apr 6, 2026
Conversation
|
GNU testsuite comparison: |
…has no unit suffix
|
GNU testsuite comparison: |
Contributor
|
Thanks for your PR! |
kevinburkesegment
pushed a commit
to kevinburkesegment/coreutils
that referenced
this pull request
Apr 6, 2026
…uffix and fixed String format (uutils#11674) * numfmt: preserve fractional digits when --from-unit is used without suffix and fixed String format * numfmt: simplify redundant if branches caught by clippy * numfmt: fix precision condition to only preserve decimals when input has no unit suffix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11663
When from-unit multiplies a fractional input with no unit suffix, uutils was rounding the result to an integer instead of preserving the fractional digits as GNU does.
Fixes conducted by making two changes in format.rs:
Removed #[ignore] from the existing test so that all tests now pass.