Skip to content

uucore: add missing feature of rustix#11632

Merged
sylvestre merged 1 commit intouutils:mainfrom
oech3:rustix-fs
Apr 4, 2026
Merged

uucore: add missing feature of rustix#11632
sylvestre merged 1 commit intouutils:mainfrom
oech3:rustix-fs

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Apr 4, 2026

error[E0433]: failed to resolve: could not find `fs` in `rustix`
   --> src/uucore/src/lib/features/pipes.rs:80:24
    |
 80 |     let stat = rustix::fs::fstat(&null).ok()?;
    |                        ^^ could not find `fs` in `rustix`
    |
note: found an item that was configured out
   --> /tmp/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-1.1.4/src/lib.rs:226:9
    |
224 | #[cfg(feature = "fs")]
    |       -------------- the item is gated behind the `fs` feature
225 | #[cfg_attr(docsrs, doc(cfg(feature = "fs")))]
226 | pub mod fs;
    |         ^^
note: found an item that was configured out
   --> /tmp/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-1.1.4/src/lib.rs:336:16
    |
327 |       any(
    |  ________-
328 | |         feature = "param",
329 | |         feature = "runtime",
330 | |         feature = "thread",
331 | |         feature = "time",
332 | |         target_arch = "x86",
333 | |     )
    | |_____- the item is gated here
...
336 |   pub(crate) mod fs;
    |                  ^^

error[E0433]: failed to resolve: could not find `fs` in `rustix`
   --> src/uucore/src/lib/features/pipes.rs:82:17
    |
 82 |     if (rustix::fs::major(dev), rustix::fs::minor(dev)) == (1, 3) {
    |                 ^^ could not find `fs` in `rustix`
    |
note: found an item that was configured out
   --> /tmp/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-1.1.4/src/lib.rs:226:9
    |
224 | #[cfg(feature = "fs")]
    |       -------------- the item is gated behind the `fs` feature
225 | #[cfg_attr(docsrs, doc(cfg(feature = "fs")))]
226 | pub mod fs;
    |         ^^
note: found an item that was configured out
   --> /tmp/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-1.1.4/src/lib.rs:336:16
    |
327 |       any(
    |  ________-
328 | |         feature = "param",
329 | |         feature = "runtime",
330 | |         feature = "thread",
331 | |         feature = "time",
332 | |         target_arch = "x86",
333 | |     )
    | |_____- the item is gated here
...
336 |   pub(crate) mod fs;
    |                  ^^

error[E0433]: failed to resolve: could not find `fs` in `rustix`
   --> src/uucore/src/lib/features/pipes.rs:82:41
    |
 82 |     if (rustix::fs::major(dev), rustix::fs::minor(dev)) == (1, 3) {
    |                                         ^^ could not find `fs` in `rustix`
    |
note: found an item that was configured out
   --> /tmp/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-1.1.4/src/lib.rs:226:9
    |
224 | #[cfg(feature = "fs")]
    |       -------------- the item is gated behind the `fs` feature
225 | #[cfg_attr(docsrs, doc(cfg(feature = "fs")))]
226 | pub mod fs;
    |         ^^
note: found an item that was configured out
   --> /tmp/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-1.1.4/src/lib.rs:336:16
    |
327 |       any(
    |  ________-
328 | |         feature = "param",
329 | |         feature = "runtime",
330 | |         feature = "thread",
331 | |         feature = "time",
332 | |         target_arch = "x86",
333 | |     )
    | |_____- the item is gated here
...
336 |   pub(crate) mod fs;
    |                  ^^

@oech3 oech3 marked this pull request as ready for review April 4, 2026 09:38
@oech3 oech3 changed the title uucore: Ad missing feature of rustix uucore: add missing feature of rustix Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.

@sylvestre sylvestre merged commit 60d448b into uutils:main Apr 4, 2026
112 of 165 checks passed
@oech3 oech3 deleted the rustix-fs branch April 4, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants