Skip to content

cat: add WASI stub for is_unsafe_overwrite and add to feat_wasm#11573

Merged
cakebaker merged 1 commit intouutils:mainfrom
sylvestre:wasm-pr7
Apr 2, 2026
Merged

cat: add WASI stub for is_unsafe_overwrite and add to feat_wasm#11573
cakebaker merged 1 commit intouutils:mainfrom
sylvestre:wasm-pr7

Conversation

@sylvestre
Copy link
Copy Markdown
Contributor

WASI has no fstat-based device/inode checks, so always return false (assume safe) for the overwrite detection.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/rm/isatty (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cut/cut-huge-range is now passing!
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!

@cakebaker
Copy link
Copy Markdown
Contributor

This PR seems to be a duplicate of #11571

WASI has no fstat-based device/inode checks, so always return false
(assume safe) for the overwrite detection.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 1, 2026

Merging this PR will degrade performance by 5.21%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 303 untouched benchmarks
⏩ 46 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cp_large_file[16] 263.6 µs 278.1 µs -5.21%

Comparing sylvestre:wasm-pr7 (418e139) with main (1e81775)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/rm/isatty (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!

@sylvestre sylvestre marked this pull request as ready for review April 1, 2026 20:22
@sylvestre sylvestre requested a review from cakebaker April 1, 2026 20:22
@cakebaker cakebaker merged commit e510449 into uutils:main Apr 2, 2026
164 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants