sort: fix warnings about unused stuff on Redox#11547
Merged
sylvestre merged 1 commit intouutils:mainfrom Mar 30, 2026
Merged
Conversation
|
GNU testsuite comparison: |
4bf2e9c to
6d74ff7
Compare
Merging this PR will improve performance by 4.63%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | cp_large_file[16] |
278 µs | 265.7 µs | +4.63% |
Comparing cakebaker:sort_fix_warnings_on_redox (6d74ff7) with main (c7710ac)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
kevinburkesegment
pushed a commit
to kevinburkesegment/coreutils
that referenced
this pull request
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some warnings about unused imports and an unused function on Redox. See, for example, https://github.com/uutils/coreutils/actions/runs/23742274684/job/69162751126?pr=11495#step:17:282: