head: fix error message when input is a directory#11541
Merged
cakebaker merged 2 commits intouutils:mainfrom Mar 30, 2026
Merged
head: fix error message when input is a directory#11541cakebaker merged 2 commits intouutils:mainfrom
cakebaker merged 2 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Contributor
|
The test currently fails on Windows, you probably have to gate it. |
Contributor
Author
I will try to move the directory check before File::open, using std::path::Path::is_dir(), it should work on Windows too, wdyt? |
Merging this PR will degrade performance by 4.8%
Performance Changes
Comparing Footnotes
|
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
kevinburkesegment
pushed a commit
to kevinburkesegment/coreutils
that referenced
this pull request
Apr 6, 2026
* head: fix error message when input is a directory * head: check for directory before trying to open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11485
head .incorrectly reports:It should report:
The cause:
io::copycan fail from either the read or write side,but the error was always attributed to stdout viawrap_in_stdout_error.