yes: use tee syscall as fast-path by oech3 · Pull Request #11458 · uutils/coreutils

oech3 · 2026-03-23T00:00:37Z

Add zero-copy fast-path ~~only valid for pipe output~~.

~~sendfile code-path is still needed for the case GNU added -z for fast zero generator.~~

Closes #11454 .

codspeed-hq · 2026-03-23T00:18:05Z

Merging this PR will not alter performance

✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks¹

_{Comparing oech3:yes-tee (7921d38) with main (b352f83)}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-03-23T00:36:16Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/seq/seq-epipe is no longer failing!

github-actions · 2026-03-23T01:04:48Z

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/seq/seq-epipe is no longer failing!
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.

github-actions · 2026-03-23T01:47:48Z

GNU testsuite comparison:

Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

github-actions · 2026-03-23T06:36:53Z

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/expand/bounded-memory is now passing!

github-actions · 2026-03-23T08:01:54Z

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!

github-actions · 2026-03-23T09:43:07Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!

github-actions · 2026-03-23T10:36:46Z

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout-group. tests/timeout/timeout-group is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

github-actions · 2026-03-23T11:33:58Z

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

oech3 · 2026-03-23T12:52:26Z

It seems tee is faster than vmsplice with enough RAM (bandwidth?)

> taskset -c 1 yes-tee|taskset -c 2 pv>/dev/null
[50.9GiB/s]
> taskset -c 1 yes-vmsplice|taskset -c 2 pv>/dev/null
[47.5GiB/s]

> taskset -c 1 gnu5ec45a1aa/yes|taskset -c 2 pv>/dev/null
[49.6GiB/s]

and LD_PRELOAD=/usr/lib/libmimalloc.so does not help with enough RAM.
@ArniDagur

github-actions · 2026-03-23T12:52:28Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

github-actions · 2026-03-23T13:06:57Z

GNU testsuite comparison:

GNU test failed: tests/rm/isatty. tests/rm/isatty is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/csplit/csplit-heap is now passing!

github-actions · 2026-04-01T19:42:22Z

GNU testsuite comparison:

GNU test failed: tests/cp/parent-perm-race. tests/cp/parent-perm-race is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!

github-actions · 2026-04-02T09:57:28Z

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Congrats! The gnu test tests/cut/bounded-memory is now passing!
Congrats! The gnu test tests/tail/pipe-f is now passing!

github-actions · 2026-04-02T10:11:04Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cut/bounded-memory is now passing!
Congrats! The gnu test tests/tail/pipe-f is now passing!

github-actions · 2026-04-04T09:41:16Z

GNU testsuite comparison:

Skip an intermittent issue tests/rm/isatty (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

github-actions · 2026-04-04T09:54:17Z

GNU testsuite comparison:

Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

github-actions · 2026-04-05T11:50:37Z

GNU testsuite comparison:

GNU test failed: tests/seq/seq-epipe. tests/seq/seq-epipe is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/pipe-f2. tests/tail/pipe-f2 is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.

github-actions · 2026-04-05T12:16:07Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!

github-actions · 2026-04-06T15:42:24Z

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout-group. tests/timeout/timeout-group is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.

github-actions · 2026-04-07T01:17:30Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/cp/link-heap is now passing!

oech3 · 2026-04-07T03:43:47Z

@cakebaker would you review this?

github-actions · 2026-04-09T18:25:45Z

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)

github-actions · 2026-04-10T08:05:24Z

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (was skipped on 'main', now failing)

src/uucore/src/lib/features/pipes.rs

github-actions · 2026-04-10T10:07:20Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!

oech3 force-pushed the yes-tee branch 3 times, most recently from 57ce5eb to 1506d10 Compare March 23, 2026 00:15

oech3 force-pushed the yes-tee branch 2 times, most recently from 0c0949b to 32606d4 Compare March 23, 2026 00:28

oech3 force-pushed the yes-tee branch from 32606d4 to 9dd7151 Compare March 23, 2026 00:55

oech3 marked this pull request as ready for review March 23, 2026 01:31

oech3 force-pushed the yes-tee branch from 9dd7151 to 6afeb8c Compare March 23, 2026 01:39

oech3 force-pushed the yes-tee branch from 6afeb8c to 48e65e9 Compare March 23, 2026 06:27

oech3 force-pushed the yes-tee branch from 48e65e9 to 10449b6 Compare March 23, 2026 07:51

This comment was marked as resolved.

Sign in to view

oech3 force-pushed the yes-tee branch from 10449b6 to d90f019 Compare March 23, 2026 09:30

oech3 force-pushed the yes-tee branch from d90f019 to 58285e2 Compare March 23, 2026 10:23

This comment was marked as outdated.

Sign in to view

oech3 force-pushed the yes-tee branch from 58285e2 to fea6807 Compare March 23, 2026 11:22

oech3 force-pushed the yes-tee branch from fea6807 to 6a9505a Compare March 23, 2026 12:40

oech3 force-pushed the yes-tee branch from 6a9505a to 6be7b39 Compare March 23, 2026 12:52

oech3 mentioned this pull request Mar 23, 2026

tests, yes: Support more syscall failure coreutils/coreutils#227

Closed

This comment was marked as resolved.

Sign in to view

oech3 force-pushed the yes-tee branch 2 times, most recently from 79e0bba to 559cb71 Compare April 2, 2026 09:28

oech3 force-pushed the yes-tee branch from 559cb71 to ce30c51 Compare April 2, 2026 10:01

oech3 mentioned this pull request Apr 3, 2026

head: splice fast-path for -c #11620

Draft

oech3 force-pushed the yes-tee branch from ce30c51 to 4005f8e Compare April 4, 2026 09:22

oech3 force-pushed the yes-tee branch from 262c9e3 to 14452bc Compare April 5, 2026 11:43

oech3 force-pushed the yes-tee branch from 14452bc to 4ce4246 Compare April 5, 2026 11:59

oech3 force-pushed the yes-tee branch from 4ce4246 to bce7359 Compare April 6, 2026 15:35

oech3 force-pushed the yes-tee branch from bce7359 to cdd13cd Compare April 7, 2026 01:10

oech3 force-pushed the yes-tee branch from cdd13cd to 786a444 Compare April 9, 2026 18:10

This comment was marked as outdated.

Sign in to view

oech3 force-pushed the yes-tee branch from 786a444 to 01d1b12 Compare April 10, 2026 07:45

yes: use tee syscall as fast-path

7921d38

RenjiSann reviewed Apr 10, 2026

View reviewed changes

src/uucore/src/lib/features/pipes.rs Outdated Show resolved Hide resolved

oech3 force-pushed the yes-tee branch from 01d1b12 to 7921d38 Compare April 10, 2026 09:58

oech3 requested a review from RenjiSann April 10, 2026 10:55

Uh oh!

Conversation

oech3 commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

This comment was marked as resolved.

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

This comment was marked as outdated.

github-actions bot commented Mar 23, 2026

Uh oh!

oech3 commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

This comment was marked as resolved.

github-actions bot commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

github-actions bot commented Apr 5, 2026

Uh oh!

github-actions bot commented Apr 5, 2026

Uh oh!

github-actions bot commented Apr 6, 2026

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

oech3 commented Apr 7, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

This comment was marked as outdated.

github-actions bot commented Apr 10, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

oech3 commented Mar 23, 2026 •

edited

Loading

codspeed-hq bot commented Mar 23, 2026 •

edited

Loading