sort: add locale-aware month sorting (-M) by sylvestre · Pull Request #11445 · uutils/coreutils

sylvestre · 2026-03-21T21:52:43Z

No description provided.

github-actions · 2026-03-21T22:01:28Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

github-actions · 2026-03-21T22:30:56Z

GNU testsuite comparison:

GNU test failed: tests/rm/isatty. tests/rm/isatty is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

github-actions · 2026-03-21T22:47:47Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

github-actions · 2026-03-21T23:05:53Z

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

github-actions · 2026-03-22T08:34:35Z

GNU testsuite comparison:

GNU test failed: tests/rm/isatty. tests/rm/isatty is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

github-actions · 2026-03-22T16:39:43Z

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Congrats! The gnu test tests/basenc/bounded-memory is now passing!
Congrats! The gnu test tests/tail/pipe-f is now passing!
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

github-actions · 2026-03-22T17:49:36Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!

github-actions · 2026-03-22T18:58:51Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

github-actions · 2026-03-22T21:08:08Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!

tests/by-util/test_sort.rs

cakebaker · 2026-03-24T10:01:28Z

tests/by-util/test_sort.rs

+    let expected = months.iter().fold(String::new(), |mut s, m| {
+        writeln!(s, "{m}").unwrap();
+        s
+    });


Using join might be easier to read:

Suggested change

let expected = months.iter().fold(String::new(), |mut s, m| {

writeln!(s, "{m}").unwrap();

s

});

let expected = months.join("\n") + "\n";

tests/by-util/test_sort.rs

cakebaker · 2026-03-24T15:13:39Z

src/uu/sort/src/sort.rs

                    let initial_selection = &self.line[selection.clone()];
-
-                    let mut month_chars = initial_selection
+                    let trimmed = initial_selection


The name trimmed is a bit misleading as it contains a position (and not a trimmed string).

cakebaker · 2026-03-24T15:46:08Z

src/uu/sort/src/sort.rs

+                        trimmed..trimmed
                    } else {
-                        // We parsed a month. Match the first three non-whitespace characters, which must be the month we parsed.
-                        month_chars.next().unwrap().0
-                            ..month_chars
-                                .nth(2)
-                                .map_or(initial_selection.len(), |(idx, _)| idx)
+                        // We parsed a month. Use the actual match byte length.
+                        trimmed..(trimmed + match_len)


It might make sense to set selection.start and selection.end directly in the if/else blocks instead of returning a range.

src/uu/sort/src/sort.rs

github-actions · 2026-03-25T22:26:47Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!

codspeed-hq · 2026-03-25T22:36:12Z

Merging this PR will not alter performance

✅ 304 untouched benchmarks
⏩ 46 skipped benchmarks¹

_{Comparing sylvestre:sort-month (3f6c71b) with main (aa7a886)}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-03-31T15:18:58Z

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/rm/isatty (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Congrats! The gnu test tests/csplit/csplit-heap is now passing!
Congrats! The gnu test tests/tail/tail-n0f is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

github-actions · 2026-03-31T15:44:07Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/rm/isatty (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Congrats! The gnu test tests/csplit/csplit-heap is now passing!
Congrats! The gnu test tests/tail/tail-n0f is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

github-actions · 2026-04-01T08:23:12Z

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!

fix: tests/sort/sort-month.sh

…vailable()

github-actions · 2026-04-01T10:19:37Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.

cakebaker · 2026-04-01T12:37:14Z

Congrats! The gnu test tests/sort/sort-month is no longer failing!

Kudos!

sylvestre force-pushed the sort-month branch from 288aa3b to 61837f2 Compare March 21, 2026 22:21

sylvestre force-pushed the sort-month branch 2 times, most recently from 3377348 to aa3ca32 Compare March 21, 2026 22:39

sylvestre force-pushed the sort-month branch from aa3ca32 to c540b33 Compare March 21, 2026 22:56

sylvestre force-pushed the sort-month branch from c540b33 to 83362e5 Compare March 22, 2026 08:24

sylvestre force-pushed the sort-month branch 2 times, most recently from 146a915 to afbe750 Compare March 22, 2026 16:08

sylvestre force-pushed the sort-month branch from afbe750 to 817e7f7 Compare March 22, 2026 17:39

sylvestre force-pushed the sort-month branch from 817e7f7 to aa4c91c Compare March 22, 2026 18:49

sylvestre marked this pull request as ready for review March 22, 2026 18:53

sylvestre force-pushed the sort-month branch from aa4c91c to 136c45a Compare March 22, 2026 20:59

sylvestre requested review from ChrisDryden and cakebaker March 22, 2026 21:33

cakebaker reviewed Mar 24, 2026

View reviewed changes

tests/by-util/test_sort.rs Outdated Show resolved Hide resolved

cakebaker reviewed Mar 24, 2026

View reviewed changes

tests/by-util/test_sort.rs Show resolved Hide resolved

cakebaker reviewed Mar 24, 2026

View reviewed changes

src/uu/sort/src/sort.rs Show resolved Hide resolved

cakebaker reviewed Mar 25, 2026

View reviewed changes

src/uu/sort/src/sort.rs Show resolved Hide resolved

sylvestre force-pushed the sort-month branch from 136c45a to db31d43 Compare March 25, 2026 22:10

sylvestre force-pushed the sort-month branch from db31d43 to 326728e Compare March 31, 2026 15:07

sylvestre requested a review from cakebaker March 31, 2026 15:09

sylvestre force-pushed the sort-month branch from 326728e to b94100f Compare March 31, 2026 15:29

sylvestre force-pushed the sort-month branch from b94100f to 89d4cd3 Compare April 1, 2026 08:07

sylvestre force-pushed the sort-month branch from 89d4cd3 to f623c60 Compare April 1, 2026 09:52

sylvestre added 2 commits April 1, 2026 12:08

sort: add locale-aware month sorting (-M)

a2522da

fix: tests/sort/sort-month.sh

tests: deduplicate locale availability checks into shared is_locale_a…

3f6c71b

…vailable()

sylvestre force-pushed the sort-month branch from f623c60 to 3f6c71b Compare April 1, 2026 10:08

cakebaker merged commit ffa088d into uutils:main Apr 1, 2026
165 checks passed

sylvestre deleted the sort-month branch April 1, 2026 20:36

moonfruit mentioned this pull request Apr 7, 2026

uutils-selected 0.8.0 moonfruit/homebrew-tap#518

Closed

Uh oh!

Conversation

sylvestre commented Mar 21, 2026

Uh oh!

github-actions bot commented Mar 21, 2026

Uh oh!

github-actions bot commented Mar 21, 2026

Uh oh!

github-actions bot commented Mar 21, 2026

Uh oh!

github-actions bot commented Mar 21, 2026

Uh oh!

github-actions bot commented Mar 22, 2026

Uh oh!

github-actions bot commented Mar 22, 2026

Uh oh!

github-actions bot commented Mar 22, 2026

Uh oh!

github-actions bot commented Mar 22, 2026

Uh oh!

github-actions bot commented Mar 22, 2026

Uh oh!

Uh oh!

cakebaker Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cakebaker Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cakebaker Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

codspeed-hq bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

Uh oh!

cakebaker commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cakebaker Mar 24, 2026 •

edited

Loading

codspeed-hq bot commented Mar 25, 2026 •

edited

Loading