Skip to content

protect names against binary name#11378

Merged
sylvestre merged 2 commits intouutils:mainfrom
oech3:test-name
Apr 4, 2026
Merged

protect names against binary name#11378
sylvestre merged 2 commits intouutils:mainfrom
oech3:test-name

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 18, 2026

Closes #11343 . Should reduce binary size too

@oech3 oech3 force-pushed the test-name branch 2 times, most recently from e418e35 to 81ec735 Compare March 18, 2026 03:10
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 18, 2026

Merging this PR will degrade performance by 16.92%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 3 regressed benchmarks
✅ 302 untouched benchmarks
⏩ 46 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cat_default[10000] 67.2 KB 80.9 KB -16.92%
Simulation cat_default[10000] 188.6 µs 198.8 µs -5.14%
Simulation cat_default[10000000] 86.1 µs 89.5 µs -3.86%

Comparing oech3:test-name (66b0639) with main (60d448b)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (13fb3be) during the generation of this report, so 60d448b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 18, 2026

Merging this PR will degrade performance by 37.71%

Too large perf drop

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 18, 2026

I have no idea why is this bad for CPU perf.

@cakebaker cakebaker changed the title protest names against binary name protect names against binary name Mar 18, 2026
@oech3

This comment was marked as resolved.

@sylvestre
Copy link
Copy Markdown
Contributor

I have no idea why is this bad for CPU perf.

i guess a change in the compiler version or codspeed ?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 18, 2026

It did not happen at other PR. I guess this changes compiler's optimization.

@oech3 oech3 force-pushed the test-name branch 4 times, most recently from c3364a5 to 6a622d6 Compare March 18, 2026 08:38
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 18, 2026

I think we need to uucore::localized_help_template lazy to improve help.

@oech3 oech3 force-pushed the test-name branch 2 times, most recently from 1b1e2aa to 79ef90b Compare March 18, 2026 09:18
@oech3 oech3 marked this pull request as ready for review March 18, 2026 09:18
@oech3

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/pipe-f is now passing!

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/pipe-f is now passing!

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

@oech3 oech3 force-pushed the test-name branch 2 times, most recently from 930ebe5 to e52fcd9 Compare March 22, 2026 21:24
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/seq/seq-epipe is no longer failing!
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/expand/bounded-memory is now passing!

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/csplit/csplit-heap is now passing!

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 24, 2026

Too many CI failure

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)

@oech3 oech3 force-pushed the test-name branch 2 times, most recently from c9bd97b to 8dd1e69 Compare March 25, 2026 19:18
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 25, 2026

dirname might wrong at here.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)

@oech3

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f was skipped on 'main' but is now failing.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 29, 2026

Is this OK to merge?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cut/cut-huge-range is now passing!
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@sylvestre sylvestre merged commit e170b9a into uutils:main Apr 4, 2026
166 of 167 checks passed
@oech3 oech3 deleted the test-name branch April 4, 2026 11:07
kevinburkesegment pushed a commit to kevinburkesegment/coreutils that referenced this pull request Apr 6, 2026
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all: name of individual binaries are hijacked by argv[0]

2 participants