Skip to content

stty: Fix incorrect ppc64el type presumption#11284

Merged
sylvestre merged 2 commits intouutils:mainfrom
BAMF0:fix-ftbfs-ppc64el-stty
Mar 11, 2026
Merged

stty: Fix incorrect ppc64el type presumption#11284
sylvestre merged 2 commits intouutils:mainfrom
BAMF0:fix-ftbfs-ppc64el-stty

Conversation

@BAMF0
Copy link
Copy Markdown
Contributor

@BAMF0 BAMF0 commented Mar 10, 2026

This pull request will make the function print_terminal_size assume that speed is of type u32 on PowerPC64 systems using little-endian. Additionally, it will structure the cfg attributes to separate target_os from target_arch for clarity.

Fixes #11282

@BAMF0
Copy link
Copy Markdown
Contributor Author

BAMF0 commented Mar 10, 2026

It seems that the formatter does not agree with my choice of structuring the attributes, let me fix that.

@xtqqczze
Copy link
Copy Markdown
Contributor

@BAMF0 Do tests pass on a powerpc64le target, I don't think we have coverage in CI.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Congrats! The gnu test tests/cut/cut-huge-range is now passing!

@sylvestre sylvestre merged commit 913654b into uutils:main Mar 11, 2026
159 checks passed
@sylvestre
Copy link
Copy Markdown
Contributor

Merci

sylvestre pushed a commit to sylvestre/coreutils that referenced this pull request Mar 18, 2026
* stty: Fix incorrect ppc64el type presumption

* stty: Run cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PowerPC64 targets using Little-endian fails to build

3 participants