refactor: replace manual last()+pop() patterns with Vec::pop_if#11272
Merged
sylvestre merged 1 commit intouutils:mainfrom Mar 10, 2026
Merged
refactor: replace manual last()+pop() patterns with Vec::pop_if#11272sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
…thod Replace manual checks for last element existence and condition with the new pop_if() method for cleaner, more idiomatic code across multiple utilities (dd, nl, paste, shuf, uniq). This change improves code readability and reduces boilerplate while maintaining identical functionality.
|
GNU testsuite comparison: |
sylvestre
pushed a commit
to sylvestre/coreutils
that referenced
this pull request
Mar 18, 2026
…thod (uutils#11272) Replace manual checks for last element existence and condition with the new pop_if() method for cleaner, more idiomatic code across multiple utilities (dd, nl, paste, shuf, uniq). This change improves code readability and reduces boilerplate while maintaining identical functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last()+pop()patterns withVec::pop_ifshuf,uniq,nl,dd, andpasteassert_eq!(output.pop(), ...)inpasteThis is a small refactor enabled by the current MSRV and is not intended to change behavior.