uucore: share a fluent resource between threads - dd perf + 45%#11220
uucore: share a fluent resource between threads - dd perf + 45%#11220sylvestre merged 1 commit intouutils:mainfrom
Conversation
Merging this PR will improve performance by ×6.8
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | dd_copy_1m_blocks |
1.4 ms | 1.2 ms | +11.3% |
| ⚡ | Simulation | dd_copy_8k_blocks |
913.6 µs | 772.1 µs | +18.32% |
| ⚡ | Simulation | dd_copy_with_seek |
2.2 ms | 2 ms | +7.02% |
| ⚡ | Simulation | dd_copy_4k_blocks |
1.2 ms | 1.1 ms | +12.44% |
| ⚡ | Simulation | dd_copy_64k_blocks |
501.5 µs | 365.8 µs | +37.11% |
| ⚡ | Simulation | dd_copy_with_skip |
2.1 ms | 2 ms | +6.9% |
| ⚡ | Simulation | dd_copy_partial |
455.8 µs | 314.6 µs | +44.85% |
| ⚡ | Memory | dd_copy_with_skip |
103.2 KB | 18.4 KB | ×5.6 |
| ⚡ | Memory | dd_copy_4k_blocks |
102.9 KB | 18.1 KB | ×5.7 |
| ⚡ | Memory | dd_copy_with_seek |
103.2 KB | 18.4 KB | ×5.6 |
| ⚡ | Memory | dd_copy_separate_blocks |
178.3 KB | 137.2 KB | +29.95% |
| ⚡ | Memory | dd_copy_default |
99.5 KB | 14.7 KB | ×6.8 |
| ⚡ | Memory | dd_copy_partial |
102.9 KB | 18.1 KB | ×5.7 |
| ⚡ | Memory | dd_copy_1m_blocks |
1.1 MB | 1 MB | +8.17% |
| ⚡ | Memory | dd_copy_8k_blocks |
106.9 KB | 22.1 KB | ×4.8 |
| ⚡ | Memory | dd_copy_64k_blocks |
162.9 KB | 78.1 KB | ×2.1 |
Comparing oech3:sort-exec-malloc (a2b9ad3) with main (ff6dd99)
Footnotes
-
48 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
a3d65d4 to
9c4c16b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
GNU testsuite comparison: |
|
Not too easy |
|
GNU testsuite comparison: |
05d100c to
182f69a
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This comment was marked as outdated.
This comment was marked as outdated.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
@ChrisDryden Is this OK for you? |
|
@sylvestre Is this ok to merge? |
|
GNU testsuite comparison: |
|
ok? |
|
Hmm... performance drop by |
Closes #11236