Skip to content

deps: replace ahash with foldhash#11187

Merged
sylvestre merged 1 commit intouutils:mainfrom
xtqqczze:deps/foldhash
Mar 4, 2026
Merged

deps: replace ahash with foldhash#11187
sylvestre merged 1 commit intouutils:mainfrom
xtqqczze:deps/foldhash

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Mar 3, 2026

Drop ahash dependency in favor of hashbrown's default hasher.

https://codspeed.io/uutils/coreutils/branches/xtqqczze%3Adeps%2Ffoldhash

cc: @oech3

@xtqqczze xtqqczze mentioned this pull request Mar 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/tail-n0f. tests/tail/tail-n0f is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)

@xtqqczze xtqqczze marked this pull request as ready for review March 3, 2026 13:14
exacl = "0.12.0"
file_diff = "1.0.0"
filetime = "0.2.23"
foldhash = "0.2.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you wrote:

we already use foldhash so this is one less dependency

so, why do you have to add it here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it is transitive dep

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Mar 4, 2026

@oech3 has binary size reduced?

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented Mar 4, 2026

I cannot check soon, but OK to merge as perf gains 1%.

@sylvestre sylvestre merged commit 43555b0 into uutils:main Mar 4, 2026
162 of 164 checks passed
@xtqqczze xtqqczze deleted the deps/foldhash branch March 6, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants