deps: replace ahash with foldhash#11187
Merged
sylvestre merged 1 commit intouutils:mainfrom Mar 4, 2026
Merged
Conversation
Merged
|
GNU testsuite comparison: |
sylvestre
reviewed
Mar 4, 2026
| exacl = "0.12.0" | ||
| file_diff = "1.0.0" | ||
| filetime = "0.2.23" | ||
| foldhash = "0.2.0" |
Contributor
There was a problem hiding this comment.
you wrote:
we already use foldhash so this is one less dependency
so, why do you have to add it here?
Contributor
Author
|
@oech3 has binary size reduced? |
Contributor
|
I cannot check soon, but OK to merge as perf gains 1%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
ahashdependency in favor ofhashbrown's default hasher.ahashcan be slow as it is reliant on hardware support for AES-based instructions.ahashuses different algorithms depending on whether there is hardware support for AES-based instructions, fallback algorithm is slowerahashis not well maintained: Drop aHash dependency in favor of hashbrown's choice of default hasher pascalkuthe/imara-diff#17 (comment)foldhash(as a transitive dependency) so this is one less dependencyhttps://codspeed.io/uutils/coreutils/branches/xtqqczze%3Adeps%2Ffoldhash
cc: @oech3