fix(numfmt): Read lines only up to null byte (as GNU does)#11146
Merged
cakebaker merged 4 commits intouutils:mainfrom Mar 2, 2026
Merged
fix(numfmt): Read lines only up to null byte (as GNU does)#11146cakebaker merged 4 commits intouutils:mainfrom
cakebaker merged 4 commits intouutils:mainfrom
Conversation
e3be83d to
b40f15b
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 4.27%
Performance Changes
Comparing Footnotes
|
cakebaker
reviewed
Feb 28, 2026
cakebaker
reviewed
Feb 28, 2026
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11109
In cases such as "1000\x002000\n3000"
numfmtoutputs "1000\n3000\n", strongly suggesting it reads input until encountering a null byte, which makes sense in a C context.Should now mimic this behavior.
Added integration tests for this as well