fix(mv): correct selinux cfg gating for non-Linux platforms#10989
Merged
sylvestre merged 1 commit intouutils:mainfrom Feb 17, 2026
Merged
fix(mv): correct selinux cfg gating for non-Linux platforms#10989sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
The mv command was using #[cfg(feature = "selinux")] but the uucore selinux module requires both the feature AND Linux/Android target OS. This caused build failures on macOS when the selinux feature was enabled. Changed both the import and usage to use: #[cfg(all(feature = "selinux", any(target_os = "linux", target_os = "android")))] This aligns mv with other utilities (cp, install, stat, ls) that correctly gate selinux functionality.
|
GNU testsuite comparison: |
abendrothj
pushed a commit
to abendrothj/coreutils
that referenced
this pull request
Feb 17, 2026
…0989) The mv command was using #[cfg(feature = "selinux")] but the uucore selinux module requires both the feature AND Linux/Android target OS. This caused build failures on macOS when the selinux feature was enabled. Changed both the import and usage to use: #[cfg(all(feature = "selinux", any(target_os = "linux", target_os = "android")))] This aligns mv with other utilities (cp, install, stat, ls) that correctly gate selinux functionality.
abendrothj
pushed a commit
to abendrothj/coreutils
that referenced
this pull request
Feb 17, 2026
…0989) The mv command was using #[cfg(feature = "selinux")] but the uucore selinux module requires both the feature AND Linux/Android target OS. This caused build failures on macOS when the selinux feature was enabled. Changed both the import and usage to use: #[cfg(all(feature = "selinux", any(target_os = "linux", target_os = "android")))] This aligns mv with other utilities (cp, install, stat, ls) that correctly gate selinux functionality.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mv build failure on macOS when selinux feature enabled. The cfg attribute was missing target_os check, causing pre-commit hook failures on non-Linux platforms.