Skip to content

Revert "unexpand: use buffered read"#10819

Merged
sylvestre merged 1 commit intomainfrom
revert-10798-unexpand_buffer
Feb 8, 2026
Merged

Revert "unexpand: use buffered read"#10819
sylvestre merged 1 commit intomainfrom
revert-10798-unexpand_buffer

Conversation

@sylvestre
Copy link
Copy Markdown
Contributor

Reverts #10798

@sylvestre sylvestre merged commit 1f4a976 into main Feb 8, 2026
192 of 194 checks passed
@sylvestre sylvestre deleted the revert-10798-unexpand_buffer branch February 8, 2026 15:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 8, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 8, 2026

Merging this PR will degrade performance by 39.23%

❌ 2 regressed benchmarks
✅ 282 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation unexpand_large_file[10] 382.9 ms 630.1 ms -39.23%
Simulation unexpand_many_lines[100000] 182.7 ms 300.6 ms -39.22%

Comparing revert-10798-unexpand_buffer (5a2e574) with main (4c1536b)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

oech3 pushed a commit to oech3/coreutils that referenced this pull request Feb 9, 2026
cerdelen pushed a commit to cerdelen/coreutils that referenced this pull request Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant