Skip to content

Bump wincode & wincode-derive from 0.3.1 to 0.4.0#10786

Closed
cakebaker wants to merge 1 commit intouutils:mainfrom
cakebaker:wincode_crates
Closed

Bump wincode & wincode-derive from 0.3.1 to 0.4.0#10786
cakebaker wants to merge 1 commit intouutils:mainfrom
cakebaker:wincode_crates

Conversation

@cakebaker
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented Feb 7, 2026

Why don't we make a cargo update bot for all crates?

@cakebaker
Copy link
Copy Markdown
Contributor Author

@oech3 what would be the advantage of such a bot compared to renovatebot?

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented Feb 7, 2026

Less PRs.
You opened this because renovate cannot bump 2 crates. No?

@cakebaker
Copy link
Copy Markdown
Contributor Author

You opened this because renovate cannot bump 2 crates. No?

Yes.

Somehow I don't see how this cargo update bot would work without creating something like renovatebot ourselves. Maybe I'm overthinking it ;-)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@ChrisDryden
Copy link
Copy Markdown
Collaborator

Would you be open to the idea of just removing the need for wincode entirely? Its only used in one test and I we can just manually build the binary input for that test case

@cakebaker
Copy link
Copy Markdown
Contributor Author

Closing this PR as the dependencies have been removed in #10802

@cakebaker cakebaker closed this Feb 8, 2026
@cakebaker cakebaker deleted the wincode_crates branch February 8, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants