Skip to content

chore: clippy::wildcard_imports#10719

Merged
sylvestre merged 1 commit intouutils:mainfrom
nyurik:wildcard_imports
Feb 5, 2026
Merged

chore: clippy::wildcard_imports#10719
sylvestre merged 1 commit intouutils:mainfrom
nyurik:wildcard_imports

Conversation

@nyurik
Copy link
Copy Markdown
Contributor

@nyurik nyurik commented Feb 4, 2026

Usually wildcards lead to less certain code, so best to avoid it.

@sylvestre
Copy link
Copy Markdown
Contributor

needs to be fixed for windows and ubuntu

* [`clippy::wildcard_imports`](https://rust-lang.github.io/rust-clippy/master/index.html?search=wildcard_imports#wildcard_imports)

Usually wildcards lead to less certain code, so best to avoid it.
@sylvestre sylvestre merged commit 8cbc7b4 into uutils:main Feb 5, 2026
155 of 156 checks passed
@nyurik nyurik deleted the wildcard_imports branch February 5, 2026 07:12
@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Feb 5, 2026

looks like this broke openbsd:

  error[E0425]: cannot find function `get_nusers` in this scope
     --> src/uu/uptime/src/uptime.rs:194:22
      |
  194 |         user_count = get_nusers(file_path.to_str().expect("invalid utmp path file"));
      |                      ^^^^^^^^^^ not found in this scope
      |
  help: consider importing this function
      |
    8 + use uucore::uptime::get_nusers;
      |
  
      Checking uu_nproc v0.6.0 (/home/runner/work/coreutils/coreutils/src/uu/nproc)
      Checking uu_ptx v0.6.0 (/home/runner/work/coreutils/coreutils/src/uu/ptx)
  For more information about this error, try `rustc --explain E0425`.
  error: could not compile `uu_uptime` (lib) due to 1 previous error

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Feb 5, 2026

@nyurik could you please submit a PR to fix CI

@nyurik nyurik mentioned this pull request Feb 5, 2026
@nyurik
Copy link
Copy Markdown
Contributor Author

nyurik commented Feb 5, 2026

@xtqqczze sigh, CI ... fails us :) #10758

Note that I cannot test it locally - so... once again have to wait for CI :)

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Feb 5, 2026

sigh, CI ... fails us :) #10758

@sylvestre It seems the openbsd run passed despite issues: https://github.com/uutils/coreutils/actions/runs/21690274278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants