Skip to content

readlink: Set silent mode as default#10711

Merged
ChrisDryden merged 7 commits intouutils:mainfrom
denendaden:iss10578
Feb 12, 2026
Merged

readlink: Set silent mode as default#10711
ChrisDryden merged 7 commits intouutils:mainfrom
denendaden:iss10578

Conversation

@denendaden
Copy link
Copy Markdown
Contributor

This primarily changes readlink to be silent rather than verbose by default, in accordance with GNU readlink. It also makes a couple more minor changes, to bring behavior in line with GNU:

  • -s, -v, and -q can now be duplicated, and the last one takes priority
  • when POSIXLY_CORRECT is set, -s and -q are ignored entirely and it is always verbose (I am not sure if this is intentional behavior on GNU's part but it is how it currently seems to work)

Fixes #10578

@sylvestre
Copy link
Copy Markdown
Contributor

please add a test to make sure we don't regress in the future, thanks

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@ChrisDryden
Copy link
Copy Markdown
Collaborator

Seems like the windows tests are failing because its expecting the platform specific error message:

.stderr_contains("Invalid argument")

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2026

GNU testsuite comparison:

GNU test failed: tests/factor/t30. tests/factor/t30 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/t31. tests/factor/t31 is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@denendaden
Copy link
Copy Markdown
Contributor Author

Hopefully I've taken care of everything. Thanks for the assistance :)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 8, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/mv/mv-special-1. tests/mv/mv-special-1 is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

@ChrisDryden
Copy link
Copy Markdown
Collaborator

Just waiting on the CI

@ChrisDryden ChrisDryden merged commit 1c023bf into uutils:main Feb 12, 2026
153 of 155 checks passed
abendrothj pushed a commit to abendrothj/coreutils that referenced this pull request Feb 17, 2026
* readlink: Set silent mode as default

* readlink: Add tests for verbose and silent options

* readlink: Change test to work with Windows-specific error message

* readlink: Add additional test cases

---------

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

readlink: Behaviour differs from GNU Coreutils when path exists but is not a link

3 participants