readlink: Set silent mode as default#10711
Merged
ChrisDryden merged 7 commits intouutils:mainfrom Feb 12, 2026
Merged
Conversation
Contributor
|
please add a test to make sure we don't regress in the future, thanks |
|
GNU testsuite comparison: |
Collaborator
|
Seems like the windows tests are failing because its expecting the platform specific error message: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
reviewed
Feb 7, 2026
sylvestre
reviewed
Feb 7, 2026
sylvestre
reviewed
Feb 7, 2026
sylvestre
reviewed
Feb 7, 2026
sylvestre
reviewed
Feb 7, 2026
Contributor
Author
|
Hopefully I've taken care of everything. Thanks for the assistance :) |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
ChrisDryden
approved these changes
Feb 11, 2026
Collaborator
|
Just waiting on the CI |
abendrothj
pushed a commit
to abendrothj/coreutils
that referenced
this pull request
Feb 17, 2026
* readlink: Set silent mode as default * readlink: Add tests for verbose and silent options * readlink: Change test to work with Windows-specific error message * readlink: Add additional test cases --------- Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primarily changes readlink to be silent rather than verbose by default, in accordance with GNU readlink. It also makes a couple more minor changes, to bring behavior in line with GNU:
Fixes #10578