Merged
Conversation
|
GNU testsuite comparison: |
Merging this PR will improve performance by 6.63%
Performance Changes
Comparing Footnotes
|
|
GNU testsuite comparison: |
RenjiSann
reviewed
Feb 2, 2026
RenjiSann
reviewed
Feb 2, 2026
Collaborator
|
LGTM, could you squash the commits in a single one before we merge ? |
|
GNU testsuite comparison: |
ce50dad to
b6750de
Compare
|
GNU testsuite comparison: |
b6750de to
536cd28
Compare
536cd28 to
f68874d
Compare
expand: Edgecase fix expand: spelling error in comment expand: use byte literals instead of hex values for better readability
f68874d to
0400116
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading a file like /dev/zero that would never return a '\n' the read_until would never yield a buffer and therefore use up endless amount of space.
Using a static buffer we can read chunks and then process these chunks.
Fix: #10653