Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some inline comments to the new parser impl #563

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Add some inline comments to the new parser impl #563

merged 2 commits into from
Nov 15, 2021

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Nov 14, 2021

cc @Nugine @QnnOkabayashi

This just adds some inline comments to the parser implementation so it's easier for new contributors to follow.

QnnOkabayashi
QnnOkabayashi approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@QnnOkabayashi QnnOkabayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn I would've liked to have reviewed Nugine's PR but I didn't see it before this. Looks good though!

Nugine
Nugine approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@Nugine Nugine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shared/parser.rs Show resolved Hide resolved
shared/parser.rs Show resolved Hide resolved
@KodrAus
Copy link
Member Author

KodrAus commented Nov 15, 2021

Sorry @QnnOkabayashi! I'll remember to keep you CC'd on these 🙇

@KodrAus KodrAus merged commit f362d7d into uuid-rs:main Nov 15, 2021
@KodrAus KodrAus mentioned this pull request Nov 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QnnOkabayashi QnnOkabayashi QnnOkabayashi approved these changes

@Nugine Nugine Nugine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KodrAus @Nugine @QnnOkabayashi