Remove dependency on serde_derive #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
requested review from
Dylan-DPC-zz,
kinggoesgaming and
KodrAus
as code owners
|
An update: I have been trying to get the one heck of a mess that is our build system fixed. This might take sometime to get fixed. I want a good fix not just a system held together with duct tape. This is definitely on the timeline post fixing the CI infra. |
kinggoesgaming
approved these changes
Sep 2, 2020
|
hey @coolreader18 Thanks for contributing. Again sorry for the delay on getting to the PR |
|
bors r+ |
|
Build succeeded: |
|
No problem, thanks for merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a(n) other
Description
Remove the
serde_derivefeature from theserdedependency.Motivation
serde_deriveis a pretty heavy dependency that adds a lot to compile times; as it's not used in this crate outside of tests, I figured it would be ok to remove it.Tests
n/a
Related Issue(s)
#408 ?