Fixed enums for new namespacing rules #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh no I did it again! I merged #14 before this by accident :( These seem like great changes though, would you mind rebasing? |
Contributor
Author
|
np |
Contributor
Author
|
Also fixed some errors caused by rust-lang/rust#19027 |
Contributor
|
Thanks! |
alexcrichton
added a commit
that referenced
this pull request
Nov 18, 2014
Fixed enums for new namespacing rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also shortened the names of the variants to avoid repeated words (eg: ParseError::ErrorInvalidLength -> ParseError::InvalidLength).
If this is not wanted I'm happy to change them to something else.