Skip to content

Commit

Permalink
Merge #393
Browse files Browse the repository at this point in the history
393: remove the u128 feature r=Dylan-DPC a=kinggoesgaming

**I'm submitting a(n)** refactor|removal

# Description
Removes the `u128` feature. `u128` related API is available as is now. Did not 

# Motivation
`2018` edition now supports `u128`s out of the box

# Tests
Current tests should pass. No need for new tests

# Related Issue(s)
closes #366 


Co-authored-by: Hunar Roop Kahlon <[email protected]>
Co-authored-by: Dylan DPC <[email protected]>
  • Loading branch information
3 people committed Apr 4, 2019
2 parents ce195c3 + 2be0546 commit b52fdc3
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ matrix:
- rustup component add clippy-preview
- rustup target add wasm32-unknown-unknown
script:
- cargo clippy --features "u128 v1 v3 v4 v5 slog"
- cargo clippy --features "v1 v3 v4 v5 slog"
- cargo build --target wasm32-unknown-unknown --features "v3 wasm-bindgen"
- cargo build --target wasm32-unknown-unknown --features "v4 wasm-bindgen"
- cargo build --target wasm32-unknown-unknown --features "v5 wasm-bindgen"
Expand Down
6 changes: 1 addition & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ features = [ "guid", "serde", "slog", "v1", "v3", "v4", "v5" ]
default-target = "x86_64-pc-windows-msvc"

[package.metadata.playground]
features = ["serde", "u128", "v1", "v3", "v4", "v5"]
features = ["serde", "v1", "v3", "v4", "v5"]

[badges.appveyor]
repository = "uuid-rs/uuid"
Expand All @@ -46,7 +46,6 @@ repository = "uuid-rs/uuid"
[dependencies.byteorder]
default-features = false
features = ["i128"]
optional = true
version = "1"

[dependencies.md5]
Expand Down Expand Up @@ -94,9 +93,6 @@ v4 = ["rand"]
v5 = ["sha1"]
wasm-bindgen = ["rand/wasm-bindgen"]

# since rust 1.26.0
u128 = ["byteorder"]

[target.'cfg(windows)'.dependencies.winapi]
optional = true
version = "0.3"
Expand Down
1 change: 0 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ mod slog_support;
mod std_support;
#[cfg(test)]
mod test_util;
#[cfg(feature = "u128")]
mod u128_support;
#[cfg(all(
feature = "v3",
Expand Down

0 comments on commit b52fdc3

Please sign in to comment.