Apply suggestions from code review

Co-Authored-By: Hunar Roop Kahlon <[email protected]>
uuid-rs · Jan 21, 2020 · 4899012 · 4899012
1 parent cc9e6ac
commit 4899012
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -96,7 +96,7 @@ To create a new random (V4) UUID and print it out in hexadecimal form:
 use uuid::Uuid;
 
 fn main() -> Result<(), Box<std::error::Error> {
-    let my_uuid = Uuid::new_v4().unwrap();
+    let my_uuid = Uuid::new_v4()?;
     println!("{}", my_uuid);
 }
 ```

diff --git a/src/lib.rs b/src/lib.rs
@@ -93,8 +93,8 @@
 //!
 //! use uuid::Uuid;
 //!
-//! fn main() {
-//!     let my_uuid = Uuid::new_v4().unwrap();
+//! fn main() -> Result<(), Box<std::error::Error> {
+//!     let my_uuid = Uuid::new_v4()?;
 //!     println!("{}", my_uuid);
 //! }
 //! ```

diff --git a/src/v4.rs b/src/v4.rs
@@ -22,6 +22,7 @@ impl Uuid {
     ///
     /// [`getrandom`]: https://crates.io/crates/getrandom
     /// [`rand`]: https://crates.io/crates/rand
+    // TODO: change signature to support uuid's Error.
     pub fn new_v4() -> Result<Uuid, getrandom::Error> {
         let mut bytes = [0u8; 16];
         getrandom::getrandom(&mut bytes)?;