Refactor code to follow esLint

utrad-ical · Dec 27, 2024 · c541c9d · c541c9d
1 parent b219420
commit c541c9d
Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/packages/circus-web-ui/src/pages/LoginScreen.tsx b/packages/circus-web-ui/src/pages/LoginScreen.tsx
@@ -63,7 +63,7 @@ const LoginScreen: React.FC<{}> = props => {
     if (loginSucceeded) {
       navigate('/home');
     }
-  }, [loginSucceeded]);
+  }, [loginSucceeded, navigate]);
 
   // Force logout when user shows this page
   useEffect(() => {

diff --git a/packages/circus-web-ui/src/pages/OneTimeLogin.tsx b/packages/circus-web-ui/src/pages/OneTimeLogin.tsx
@@ -53,7 +53,7 @@ const OneTimeLogin: FC = () => {
       await loginManager.refreshUserInfo(true);
       navigate(redirect || '/home');
     })();
-  }, [loginManager, pwd, redirect]);
+  }, [loginManager, pwd, redirect, navigate]);
 
   return (
     <div className="container">

diff --git a/packages/circus-web-ui/src/pages/case-detail/CaseDetail.tsx b/packages/circus-web-ui/src/pages/case-detail/CaseDetail.tsx
@@ -176,15 +176,6 @@ const CaseDetail: React.FC<{}> = () => {
     );
   }, [api, dispatch, caseStore.patientInfo, activeRelevantCases]);
 
-  if (!caseId) {
-    return null;
-  }
-
-  const handleRevisionSelect = async (index: number) => {
-    if (isUpdated && !(await confirm(pageTransitionMessage))) return;
-    caseDispatch(c.startLoadRevision({ revisionIndex: index }));
-  };
-
   const updateEditingData = useCallback<EditingDataUpdater>(
     (updater, tag) => {
       const newData = produce(editingData, updater);
@@ -201,6 +192,15 @@ const CaseDetail: React.FC<{}> = () => {
     [editingData]
   );
 
+  if (!caseId) {
+    return null;
+  }
+
+  const handleRevisionSelect = async (index: number) => {
+    if (isUpdated && !(await confirm(pageTransitionMessage))) return;
+    caseDispatch(c.startLoadRevision({ revisionIndex: index }));
+  };
+
   const handleTagChange = async (value: string[]) => {
     try {
       await api(`cases/${caseData!.caseId}/tags`, {