Skip to content
This repository was archived by the owner on Jan 12, 2022. It is now read-only.

Conversation

@GeorgianaElena
Copy link
Collaborator

@GeorgianaElena GeorgianaElena commented Feb 17, 2021

Closes #82

@GeorgianaElena GeorgianaElena changed the title Bump hub version to 0.11 [WIP] Bump hub version to 0.11 Feb 17, 2021
@GeorgianaElena
Copy link
Collaborator Author

I'm getting the following error when trying to deploy this to staging :(

Error: UPGRADE FAILED: cannot patch "hub-db-dir" with kind PersistentVolumeClaim: PersistentVolumeClaim "hub-db-dir" is invalid: spec: Forbidden: is immutable after creation except resources.requests for bound claims

@consideRatio or @yuvipanda, do you know what might be going on?

@yuvipanda
Copy link
Contributor

@GeorgianaElena oh, hmm - interesting! This looks like it's trying to change the size of the hub-db PVC, not sure why. Can you check what the current size is and see what we're asking it to be?

@GeorgianaElena
Copy link
Collaborator Author

GeorgianaElena commented Feb 17, 2021

It looks like the current size is 1Gi for the staging hub and 10Gi for the prod one.

The prod one has its size configured here, but the staging one doesn't, or at least I don't find it. Maybe the default size has changed and we should be explicit that we still want the 1Gi?

Update: Being explicit about its size, doesn't do any difference :(

@GeorgianaElena
Copy link
Collaborator Author

Thanks to a recent discussion on Gitter, I managed to get the deployment to pass by specifying the storageClassName ❤️
wieee ❤️

@yuvipanda
Copy link
Contributor

@GeorgianaElena awesome! Let's wait until Toronto is asleep before we deploy to prod? Feel free to test on staging though :)

@GeorgianaElena GeorgianaElena changed the title [WIP] Bump hub version to 0.11 Bump hub version to 0.11 Feb 17, 2021
@jsg-uoft
Copy link

@GeorgianaElena if you can let me know when you want to push the change (as well as duration although I imagine it's more or less instant) I can put up a service notice. Just good to have in case there are any night owls interacting with the system at the same time.

@yuvipanda
Copy link
Contributor

@jsg-uoft makes sense! It's pretty instant, but it's big enough that a service notice seems appropriate. Where would it be made visible?

@jsg-uoft
Copy link

@yuvipanda we'd post it to https://www.systemstatus.utoronto.ca/ and then advertise the link to the community for awareness. It may introduce a good conversation about feature changes (if any) as well!

@GeorgianaElena
Copy link
Collaborator Author

@jsg-uoft I was thinking about pushing the change at around 4am Toronto time. I could set and alarm if this needs to be precise.

@yuvipanda, the error I got before, was actually because of me messing with the config. I have now fixed it.

@yuvipanda
Copy link
Contributor

@yuvipanda we'd post it to systemstatus.utoronto.ca and then advertise the link to the community for awareness. It may introduce a good conversation about feature changes (if any) as well!

Makes sense! This shouldn't have any user facing changes I think. Thanks for being on top of it!

@jsg-uoft
Copy link

Thanks @GeorgianaElena I will post an announcement then for 4:00 a.m. Thurs. Feb. 18th (Eastern) and put a pointer to it into Teams. I'll just provide the bare bones info, so if you or @yuvipanda can monitor for questions that would be great!

@yuvipanda
Copy link
Contributor

@jsg-uoft awesome. Just make sure it says we don't expect disruption nor new features :)

Copy link

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

Note on the imagePullSecret section, create and enabled are both set but you should only need one as they are aliases. But, due to a bug in 0.11.1 you should use .create rather than .enabled if one is chosen.

@jsg-uoft
Copy link

@yuvipanda @GeorgianaElena that's it posted. Please drop me a line if you have any feedback, thanks!

@yuvipanda
Copy link
Contributor

image

This is great! Thanks :)

@GeorgianaElena
Copy link
Collaborator Author

This has now been deployed to both staging and prod 🎉 Merging it now.

@GeorgianaElena GeorgianaElena merged commit 012b64e into utoronto-2i2c:staging Feb 18, 2021
GeorgianaElena added a commit that referenced this pull request Feb 18, 2021
@GeorgianaElena GeorgianaElena mentioned this pull request Jun 28, 2021
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to z2jh 0.11

4 participants