-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/android support #101
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3159f4d
Add jvm cpp distinction by platforms
piiertho 6d50751
Differentiate jvm init arguments for android and desktop, android one…
piiertho 408fb9c
Remove exceptions in favor of error crash. Make android implem of Ini…
piiertho 6a7f44d
avoid copy jre for android export
piiertho f8964d4
Exclude java 9+ module-info for android support
chippmann 0e6f72d
Make difference between dex jars and standard jars
piiertho 2f73b2e
create class loader that load bootstrap jar for android
piiertho 9606ab0
Set bootstrap classloader as parent classloader for main jar loader o…
piiertho d3f6626
Automate dex conversion and update docs
chippmann 681e0be
Update supported targets
chippmann 7fc3dde
Fixed dex jar path in tests project
piiertho cfb254a
First try to add android build to CI using debug export
piiertho 139463f
Add android build to exports template Check PR CI
piiertho 10fa9c3
Remove android specific create class loader method
piiertho af8793f
Replace `ANDROID_HOME` with `ANDROID_SDK_ROOT` and update docs
chippmann 888152e
Remove println import
chippmann 5086273
Make jvm exception crash engine only when in debug and not TOOL
piiertho 0a0d5a6
Add aar to jre export in export plugin
piiertho 6f63cc8
Fix android export condition in export plugin
piiertho d34984c
Use parent class loader when creating a new desktop classloader on cp…
piiertho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,13 +5,16 @@ jobs: | |
build-editor-release: | ||
strategy: | ||
matrix: | ||
os: [ ubuntu-latest, macos-latest, windows-latest ] | ||
name: [ Linux, OSX, Windows ] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here - I don't think this is necessary. |
||
include: | ||
- os: ubuntu-latest | ||
- name: Linux | ||
os: ubuntu-latest | ||
platform: x11 | ||
- os: macos-latest | ||
- name: OSX | ||
os: macos-latest | ||
platform: osx | ||
- os: windows-latest | ||
- name: Windows | ||
os: windows-latest | ||
platform: windows | ||
runs-on: ${{ matrix.os }} | ||
steps: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
kt/plugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/GodotExtension.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package godot.gradle | ||
|
||
import org.gradle.api.model.ObjectFactory | ||
import org.gradle.kotlin.dsl.property | ||
|
||
open class GodotExtension(objects: ObjectFactory) { | ||
val isAndroidExportEnabled = objects.property<Boolean>() | ||
val dxToolPath = objects.property<String>() | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because on exports I had to rename it to not have confusions between x11 and android. So to keep it coherent, I renamed for all cpp jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this should contain
Android
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no editor build for android.