Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added laravel/pint & configured as linter and formatter #20

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

MagnaibayarMN
Copy link
Contributor

Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 😇 I left a comment, let' please address it.

Also, please run composer format, which will apply linting to all existing PHP files. That will make a bunch of changes, please commit those too - this is necessary for tests to pass.

composer.json Outdated
"require": {
"php": ">=7.4"
"php": ">=7.4",
"laravel/pint": "^1.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"laravel/pint": "^1.2"
"laravel/pint": "dev-main"

Let's please use this version to stay consistent with all other repositories.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I fixed them. Could you please check it out.

Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

composer.json Outdated Show resolved Hide resolved
@christyjacob4 christyjacob4 merged commit 183aa96 into utopia-php:main Oct 14, 2022
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

@stnguyen90 stnguyen90 linked an issue Nov 7, 2022 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💄 Add Code Linter To ‘utopia-php/system’
3 participants