-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added laravel/pint & configured as linter and formatter #20
Conversation
MagnaibayarMN
commented
Oct 12, 2022
- added laravel/pint package into composer.json
- added composer lint & composer format
- added .github/workflow from https://github.com/utopia-php/ab/tree/feat-code-formatter/.github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 😇 I left a comment, let' please address it.
Also, please run composer format
, which will apply linting to all existing PHP files. That will make a bunch of changes, please commit those too - this is necessary for tests to pass.
composer.json
Outdated
"require": { | ||
"php": ">=7.4" | ||
"php": ">=7.4", | ||
"laravel/pint": "^1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"laravel/pint": "^1.2" | |
"laravel/pint": "dev-main" |
Let's please use this version to stay consistent with all other repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I fixed them. Could you please check it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🎉
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |