Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implemented pint #3

Merged
merged 3 commits into from
Dec 20, 2022
Merged

feat: implemented pint #3

merged 3 commits into from
Dec 20, 2022

Conversation

byt3h3ad
Copy link
Contributor

related to issue #4361

@byt3h3ad
Copy link
Contributor Author

should i lint the existing files as well and push another commit?

@Meldiron
Copy link
Contributor

Meldiron commented Oct 13, 2022 •
edited
Loading

@byt3h3ad Yes, we need to lint existing files. Please commit those changes.

Meldiron
Meldiron requested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is existing linter in this repository. Can we make sure to remove it fully? This includes removing phpcs.xml file, all mentions of phpcs in the project, and the same for phpcbf. After that please update composer lockfile again.

Meldiron
Meldiron requested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Whoops, wrong PR. Deleting this comment 😅)

@byt3h3ad
Copy link
Contributor Author

@Meldiron all changes have been made.

Meldiron
Meldiron approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@stnguyen90 stnguyen90 linked an issue Nov 7, 2022 that may be closed by this pull request
💄 Add Code Linter To ‘utopia-php/pay’ appwrite/appwrite#4361
Closed
4 tasks
@byt3h3ad byt3h3ad closed this by deleting the head repository Nov 20, 2022
@byt3h3ad
Copy link
Contributor Author

🤦 accidentally deleted the head repo.

@byt3h3ad byt3h3ad reopened this Nov 20, 2022
@christyjacob4 christyjacob4 merged commit 771cf84 into utopia-php:main Dec 20, 2022
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💄 Add Code Linter To ‘utopia-php/pay’
3 participants
@byt3h3ad @Meldiron @christyjacob4