Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code analyzer #8

Conversation

Ambareen09
Copy link

What does this PR do?

Updated the library utopia-php/messaging and implemented a code analyzer. I used PHPStan as the analyzer.

Test Plan

Screenshot from 2022-10-14 15-54-01

No issues were found upon running the code analyzer!

Related PRs and Issues

Add Code Analyzer To ‘utopia-php/messaging’(appwrite/appwrite#4381)

Have you read the Contributing Guidelines on issues?

Yes

@Ambareen09
Copy link
Author

Please leave a review if any changes are required. Looking forward for a merge!

@stnguyen90 stnguyen90 linked an issue Oct 14, 2022 that may be closed by this pull request
5 tasks
Copy link

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please address code analysis errors 🙏 If necessary, we can lower the level of PHP Stan, that should get rid of some errors.

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@Ambareen09 Ambareen09 requested a review from Meldiron October 26, 2022 11:23
@Ambareen09
Copy link
Author

I have ignored some errors, to pass, because I was unable to figure out the correct code. Can you please guide me so as to how to fix them?

@Ambareen09
Copy link
Author

Screenshot from 2022-10-30 19-01-27

@Ambareen09
Copy link
Author

@Meldiron can you please review it?

@Meldiron
Copy link

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@stnguyen90
Copy link
Contributor

@Ambareen09 sorry for the delay. Would you please try and resolve the merge conflicts?

@stnguyen90 stnguyen90 requested review from stnguyen90 and Meldiron and removed request for Meldiron and stnguyen90 January 25, 2023 23:30
@Ambareen09
Copy link
Author

I have resolved merge conflict, can you please have a look?

tests/e2e/Base.php Outdated Show resolved Hide resolved
tests/e2e/Base.php Outdated Show resolved Hide resolved
@Ambareen09
Copy link
Author

Hello, I see you have committed a few changes, you can let me know what all modifications do I need to do in order to make this a successful PR

@Ambareen09 Ambareen09 requested review from christyjacob4 and removed request for Meldiron February 19, 2023 10:43
@abnegate
Copy link
Member

@christyjacob4 Looks like PHPStan checks are failing

@christyjacob4
Copy link
Contributor

@Ambareen09 Thanks a lot for your contributions. I'll keep this PR open so it can be resolved at a later point.

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. 

@Ambareen09
Copy link
Author

@Ambareen09 Thanks a lot for your contributions. I'll keep this PR open so it can be resolved at a later point.

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.

Hey, thanks @christyjacob4 , I have already received my swags (as I opened other PRs too).

@abnegate
Copy link
Member

Closing as implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔎 Add Code Analyzer To ‘utopia-php/messaging’
5 participants