Feat adding sms adapters #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@byawitz, thanks for the PR! 🙏🏼 it looks like there are some linter problems. Would you please address those? You should be able to run |
|
@stnguyen90 Thanks for your answer Done |
abnegate
reviewed
May 19, 2023
|
I don't know what image I should attach for the verification. Hope this one helps. Also, @abnegate I've sent you a DM with the test suite code that includes all the API keys for you to test. |
abnegate
approved these changes
Sep 14, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It added support for the following SMS providers (Adapters)
Plus I've added one document summarizing and comparing the prices for a single unit and 10K for the implemented providers.
Test Plan
I've run tests on each provider. Plivo I had for a long time and for everyone except Clickatell has a trial.
Related PRs and Issues
#17
Have you read the [Contributing Guidelines on issues]
Yes