Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clicksend-sms-adapter #15

Conversation

josua99
Copy link

@josua99 josua99 commented Feb 28, 2023

What does this PR do?

Implemented a new adapter that connects ClickSend.

Test Plan

I've successfully sent a test SMS using the new ClickSend adapter.

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

YES

Copy link

@wemiprog wemiprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be in line with the other providers. Also not seeing any problem, seems to work.
Clicksend is a nice and important provider, very cheap, simple and universally usable (not affiliated with them).
I‘d vote for approval

Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor issues. Please address the comments and add a screenshot of a successful send with this adapter 😄

src/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated Show resolved Hide resolved
src/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated Show resolved Hide resolved
@abnegate
Copy link
Member

Please also add this adapter to the list of available adapters in the README

@josua99
Copy link
Author

josua99 commented May 19, 2023

grafik
screenshot of a successful send with this adapter

src/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated Show resolved Hide resolved
src/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated Show resolved Hide resolved
src/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated Show resolved Hide resolved
src/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated Show resolved Hide resolved
src/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated Show resolved Hide resolved
@lohanidamodar lohanidamodar requested a review from abnegate August 1, 2023 02:00
@abnegate abnegate changed the base branch from main to feat-clicksend September 14, 2023 20:57
@abnegate abnegate merged commit f8314e3 into utopia-php:feat-clicksend Sep 14, 2023
@abnegate abnegate mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants