-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add clicksend-sms-adapter #15
feat: add clicksend-sms-adapter #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be in line with the other providers. Also not seeing any problem, seems to work.
Clicksend is a nice and important provider, very cheap, simple and universally usable (not affiliated with them).
I‘d vote for approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of minor issues. Please address the comments and add a screenshot of a successful send with this adapter 😄
Please also add this adapter to the list of available adapters in the README |
What does this PR do?
Implemented a new adapter that connects ClickSend.
Test Plan
I've successfully sent a test SMS using the new ClickSend adapter.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
YES