-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for wildcard and exception #29
Add support for wildcard and exception #29
Conversation
The tests for OpenSRS fails but I haven't modified anything related to OpenSRS. |
@TorstenDittmann Could you please review this? |
@wess Could you review this 😅? I can't currently use my domain since it's not supported appwrite/appwrite#5317 |
Did you pull in the latest master? There was an issue with that test but it should be addressed. |
Could you please add a test (or 2) for testing the rules? |
bfe3236
to
741bd5e
Compare
I think so. The hash of third last commit from my branch matches with master. |
Thank you for checking, if you could add those tests then i can also run the tests to see if there is any branch drift. Thanks again for the contribution, this is a killer feature. |
The last commit adds the tests. |
@wess Any updates? |
@wess, should the travis build pass? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and no issues on my end. @TorstenDittmann should this type of update be required to pass Travis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and no issues on my end. @TorstenDittmann should this type of update be required to pass Travis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add some additional test cases?
- *.nom.br
- *.kawasaki.jp
- !city.kawasaki.jp
- *.dev.adobeaemcloud.com
- adobeaemcloud.net
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!
Fix #22
Fix appwrite/appwrite#5317
Appwrite relies on public suffix list to parse domain names. According to the format specification:
Current behaviour:
The current implementation does not handle both cases. It handles suffixes without * and ! which covers all common use cases but excludes some country tld's such as *.np.
Expected behaviour: