Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DROP TABLE IF EXISTS #489

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Remove DROP TABLE IF EXISTS #489

merged 3 commits into from
Dec 2, 2024

Conversation

fogelito
Copy link
Contributor

@fogelito fogelito commented Dec 1, 2024 •
edited by stnguyen90
Loading

Remove drop table to ensure necessary tables are not accidentally deleted.

stnguyen90
stnguyen90 requested changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint error

abnegate
abnegate reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should never happen unless getCollection incorrectly returns an empty document in the Database wrapping method 🤔 maybe because of replication lag?

@abnegate abnegate merged commit 29f5e3f into 0.53.x Dec 2, 2024
15 checks passed
@abnegate abnegate deleted the 0.53.x-rm-drop-table branch December 2, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate left review comments

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fogelito @stnguyen90 @abnegate