Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix throwing global exception instead of database exception #310

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Fix throwing global exception instead of database exception #310

merged 5 commits into from
Aug 21, 2023

Conversation

abnegate
Copy link
Member

@abnegate abnegate commented Aug 21, 2023 •
edited
Loading

  • Fix throwing global exception instead of database exception in some cases
  • Add query exception so that query specific exceptions can be caught since validation happens in the library now

@abnegate abnegate requested a review from stnguyen90 August 21, 2023 21:48
abnegate
abnegate commented Aug 21, 2023
View reviewed changes
@abnegate abnegate merged commit 3e04b0a into main Aug 21, 2023
This was referenced Sep 1, 2023
Closed
Closed
@abnegate abnegate deleted the fix-exception-types branch November 23, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abnegate @stnguyen90