Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cascading deletes across multiple levels #269

Merged
merged 3 commits into from
May 16, 2023
Merged

Fix cascading deletes across multiple levels #269

merged 3 commits into from
May 16, 2023

Conversation

abnegate
Copy link
Member

@abnegate abnegate commented May 2, 2023

What's changed

  • Fix cascade deletes not accounting for nested relationships

Test plan

  • Added test to check multi-level cascade is working

@abnegate abnegate requested review from stnguyen90 and fogelito May 2, 2023 02:29
stnguyen90
stnguyen90 reviewed May 4, 2023
View reviewed changes
src/Database/Database.php Outdated Show resolved Hide resolved
src/Database/Database.php Outdated Show resolved Hide resolved
@abnegate abnegate merged commit 69a844c into main May 16, 2023
@joeyouss joeyouss mentioned this pull request Jul 28, 2023
Closed
2 tasks
@abnegate abnegate deleted the fix-multi-cascade branch November 23, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 left review comments

@fogelito fogelito fogelito approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abnegate @stnguyen90 @TorstenDittmann @fogelito