-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide our percentage of users threshold for browser support #2071
Comments
Related: it looks like the UK Government's official threshold is 2%. |
Here's my proposed solution: I think we should go with the 2% threshold, taking cues from UK Gov. They're standards is something we've followed before and is generally well researched and trusted. Going below 2% would also mean we have to support browser's we don't even currently support, and browsers that we don't have data on, and are not commonly supported in web development. As per the screenshot, going below 2% means we'd have to support IE7, which we don't currently do, meaning we'd have to go back and fix issues. We'd also have to support unknown things like Android Webview, which we don't know anything about. We should change our documentation on https://standards.usa.gov/getting-started/developers/ to reflect this decision. The documentation should not longer be about which browsers but about the percentage value of 2%. |
I like this proposal. Would this go into effect with 2.0 or something that we'd start immediately? Like could we tell users in the future "if you need support for IE9, use USWDS 1.3.1 or earlier" |
I'd go into effect with some release, it should probably be a major release if it'd cause breaking changes. |
Nice, I like it! Should we also mention that PRs to add support for < 2% browsers are welcome? That way if some team really needs IE9 support, they could add it to the standards themselves... Though we'd be under no obligation to continue ensuring that our own contributions didn't break that, I suppose. Anyways, it's an unlikely situation regardless. I like the 2% threshold. |
Just caught up reading all this -- this seems solid. Let's do it. |
This states / should state that the standards should support IE9 and up until a major release, and then will only support browsers above 2% usage on analytics.gov. This could potentially be worded in a way where it would not need to be updated in the future, such as after a major release or after browser support changes on analytics.gov. If that's better, we can rewrite it as such. Fixes uswds/uswds#2071
Done |
Description
In order for our browser support to stay up to date with current browser usage, we should pick a threshold where we decide to stop supporting a browser if it goes below a certain percentage. The percentage will be taken from https://analytics.usa.gov/.
The text was updated successfully, but these errors were encountered: