feat: browse experiment history #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrychoy
requested review from
jkglasbrenner and
hbooth
and removed request for
jkglasbrenner and
hbooth
keithmanville
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
This looks good to me.
I think the greyed out entrypoint section with the "Entrypoints are not part of Experiment snapshots" message is nicer than hiding that panel.
Adding @hbooth and @jkglasbrenner as reviewers as well since we haven't had a chance go over the design together.
This commit adds the ability for user to browse Experiment history in the view/edit form. Clicking the toggle will bring out the right drawer containing the list of snapshots. Selecting a row loads the values into the form. Up/down keyboard navigation works once focus is on the table. The table can be sorted. The Queue dialog was also updated to use this SnapshotList component.
keithmanville
force-pushed
the
experiment-history
branch
from
1614e0e to
693317a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability for user to browse Experiment history in the edit form. Clicking the toggle will bring out the right drawer containing the snapshot list, which can eventually be used in other form pages. Selecting a row loads the values into the form. Up/down keyboard navigation should work when you are clicked into the table. Table can be sorted. The queue dialog was also updated to use this SnapshotList component.