Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix invalid syntax #2078

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

wandmagic
Copy link
Collaborator

@wandmagic wandmagic commented Nov 21, 2024

Committer Notes

Two instances of a orphaned parenthesis which somehow got into develop.

I would recommend improved integration/unit tests to validate to prevent this in the future.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@wandmagic wandmagic requested a review from a team as a code owner November 21, 2024 17:10
@wandmagic wandmagic added the bug label Nov 21, 2024
@wandmagic wandmagic requested a review from iMichaela November 21, 2024 17:10
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This corrections are reasonable.

@iMichaela iMichaela merged commit 7da189b into usnistgov:develop Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants