Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing field values in Metaschema modules #2066

Merged

Conversation

david-waltermire
Copy link
Contributor

@david-waltermire david-waltermire commented Nov 11, 2024

Committer Notes

Filled in missing values for a few different Metaschema module fields. These values are required by Metaschema, but cannot be constrained in XML Schema, since they are text values of mixed content.

The absence of these values can cause errors in processing within some tools.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

…. These values are required and can cause errors in processing within some tools.
@david-waltermire david-waltermire requested a review from a team as a code owner November 11, 2024 00:37
@david-waltermire david-waltermire changed the title Added missing field values in Metaschema modules Nov 11, 2024
@david-waltermire
Copy link
Contributor Author

This appears to be failing due to a link check error. Looks like https://github.com/usnistgov/OSCAL/projects/52 is missing.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All added field values look good.

@iMichaela iMichaela merged commit db9dfc4 into usnistgov:develop Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants